Skip to content

ci: align approver gate with CODEOWNERS #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
esthor wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: align approver gate with CODEOWNERS #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
766812a
ci: align approver gate with CODEOWNERS
esthor Aug 10, 2026
99da14b
Merge branch 'main' into esthor/align-approver-gate
esthor Aug 10, 2026
08fd4b1
Merge branch 'main' into esthor/align-approver-gate
nehal-a2z Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/required-approver.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
name: verify
runs-on: ubuntu-latest
env:
REQUIRED_APPROVERS: nehal-a2z,juanpflores
REQUIRED_APPROVERS: nehal-a2z,juanpflores,esthor
GH_TOKEN: ${{ github.token }}
PR_NUMBER: ${{ github.event.pull_request.number }}
REPOSITORY: ${{ github.repository }}
Expand Down Expand Up @@ -85,7 +85,8 @@ jobs:
)"

if [[ -z "$approved_by" ]]; then
echo "::error::This PR needs an approval from nehal-a2z or juanpflores on the latest head commit."
required_display="${REQUIRED_APPROVERS//,/ or }"
echo "::error::This PR needs an approval from ${required_display} on the latest head commit."
exit 1
fi

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ All notable changes to this repository are documented in this file.

### Changed

- Aligned the required-approver check with the repository-wide CODEOWNERS.
- Aligned the shared code-review subagent metadata with Gemini CLI's schema.
- Removed alternate detailed-output guidance so review agents use `--agent`
exclusively.
Expand Down