Make CI green: executable scripts, and glib for the rust job - #2
Merged
Conversation
Both jobs have been failing since they were written, on main as well as on every branch. The docs job runs ./scripts/check-adr-index.sh, and none of the three scripts under scripts/ was ever committed with its executable bit, so the job died with "Permission denied" without checking anything. The README tells people to run ./scripts/fetch-models.sh the same way, so all three get the bit rather than the workflow getting a bash prefix. The rust job builds a workspace that reaches glib-sys through the LiveKit SDK, and the ubuntu-latest image has no glib-2.0 pkg-config metadata. Install it before the toolchain. The Docker build needs nothing: rust:bookworm carries glib 2.74.6 already. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016n12Y7LX1cWJHFRV9Jsvss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both CI jobs have been failing since they were written — on
mainas well as on every branch.docs —
./scripts/check-adr-index.sh: Permission denied. None of the three scripts underscripts/was ever committed with its executable bit, so the job died at exit 126 without checking anything.README.mdtells people to run./scripts/fetch-models.shthe same way, so all three get the bit instead of the workflow getting abashprefix.rust —
The system library glib-2.0 required by crate glib-sys was not found. The workspace reachesglib-systhrough the LiveKit SDK, and theubuntu-latestimage has noglib-2.0pkg-config metadata. Installed before the toolchain step. The Docker build needs nothing here:rust:bookwormcarries glib 2.74.6 already (checked, not recalled).The ADR index check now passes when actually run:
ADR index: 20 records, consistent.🤖 Generated with Claude Code
https://claude.ai/code/session_016n12Y7LX1cWJHFRV9Jsvss