Skip to content

Fix lib order and junit5 byte codes - #842

Merged
mernst merged 2 commits into
codespecs:masterfrom
markro49:fix-lib-order
Sep 25, 2026
Merged

mernst merged 2 commits into
codespecs:masterfrom
markro49:fix-lib-order

Conversation

@markro49

Copy link
Copy Markdown
Contributor

junit-platform-console-standalone-1.9.0-Daikon.jar contains picocli as a shadow jar and it still had Java 5 byte codes

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: codespecs/daikon/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 09534fd8-acb3-469b-b6ac-91180de91889

📥 Commits

Reviewing files that changed from the base of the PR and between fafb9d7 and 82bb6a8.

⛔ Files ignored due to path filters (1)
  • java/lib/junit-platform-console-standalone-1.9.0-Daikon.jar is excluded by !**/*.jar
📒 Files selected for processing (2)
  • java/Makefile
  • tests/daikon-tests/junit5/Makefile.user

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The Java build and JUnit 5 test makefile now list the Daikon-built JUnit 4.13.2 and Hamcrest 1.3 jars before the java/lib/* wildcard. Comments in the Java makefile describe the distributions and classpath precedence.

Suggested reviewers: mernst

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 82bb6

The updated classpath and standalone test artifact preserve the intended Java 8-compatible dependency selection. No actionable merge-blocking issue remains.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@mernst mernst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mernst
mernst merged commit 65d7a09 into codespecs:master Sep 25, 2026
64 checks passed
@mernst
mernst deleted the fix-lib-order branch September 25, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants