Skip to content

PMD linting - #844

Merged
mernst merged 2 commits into
masterfrom
linting6
Sep 24, 2026
Merged

mernst merged 2 commits into
masterfrom
linting6

Conversation

@mernst

@mernst mernst commented Sep 24, 2026

Copy link
Copy Markdown
Member

No description provided.

@mernst mernst changed the title Linting configuration PMD linting Sep 24, 2026
@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: codespecs/daikon/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 94cfd584-a795-4460-9919-7f3161b3c577

📥 Commits

Reviewing files that changed from the base of the PR and between fafb9d7 and f604d11.

📒 Files selected for processing (42)
  • java/daikon/AnnotateNullable.java
  • java/daikon/Daikon.java
  • java/daikon/DaikonSimple.java
  • java/daikon/Global.java
  • java/daikon/LogHelper.java
  • java/daikon/MergeInvariants.java
  • java/daikon/PrintInvariants.java
  • java/daikon/Quantify.java
  • java/daikon/SplitDtrace.java
  • java/daikon/UnionInvariants.java
  • java/daikon/VarInfoName.java
  • java/daikon/chicory/ChicoryPremain.java
  • java/daikon/config/HtmlToTexinfo.java
  • java/daikon/dcomp/CalcStack24.java
  • java/daikon/dcomp/Premain.java
  • java/daikon/dcomp/StackMapUtils24.java
  • java/daikon/diff/MultiDiff.java
  • java/daikon/inv/Implication.java
  • java/daikon/inv/Joiner.java
  • java/daikon/simplify/SimpUtil.java
  • java/daikon/split/ContextSplitterFactory.java
  • java/daikon/split/SplitterFactory.java
  • java/daikon/split/Visitors.java
  • java/daikon/suppress/NIS.java
  • java/daikon/test/Common.java
  • java/daikon/test/VarInfoNameDriver.java
  • java/daikon/test/diff/DiffDummyInvariant.java
  • java/daikon/tools/DtraceDiff.java
  • java/daikon/tools/DtraceNonceFixer.java
  • java/daikon/tools/ExtractConsequent.java
  • java/daikon/tools/InvMatch.java
  • java/daikon/tools/InvariantChecker.java
  • java/daikon/tools/ReadTrace.java
  • java/daikon/tools/TraceSelect.java
  • java/daikon/tools/compare/LogicalCompare.java
  • java/daikon/tools/jtb/Annotate.java
  • java/daikon/tools/jtb/Ast.java
  • java/daikon/tools/jtb/CreateSpinfo.java
  • java/daikon/tools/jtb/CreateSpinfoC.java
  • java/daikon/tools/nullness/NullnessUtil.java
  • java/daikon/tools/runtimechecker/Runtime.java
  • java/daikon/tools/runtimechecker/WriteViolationFile.java

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The changes replace Error or AssertionError with UnsupportedOperationException in private constructors that reject instantiation and in four methods each in Implication and DiffDummyInvariant that reject invocation. No other logic changes are described.

Suggested reviewers: markro49

Priority: ⬇️ Low

Change: Refactor

Merge Risk: ⚪ Minimal · up to f604d

The change standardizes exceptions for explicitly rejected operations, with no resulting behavior change identified in repository workflows; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 49.06% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 53 functions across 42 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@mernst
mernst merged commit b166939 into master Sep 24, 2026
191 checks passed
@mernst
mernst deleted the linting6 branch September 24, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant