Skip to content

Add ERB linting to the project - #1709

Draft
Oaphi wants to merge 15 commits into
developfrom
0valt/1699/erb_lint
Draft

Add ERB linting to the project#1709
Oaphi wants to merge 15 commits into
developfrom
0valt/1699/erb_lint

Conversation

@Oaphi

@Oaphi Oaphi commented Jul 24, 2025

Copy link
Copy Markdown
Member

closes #1699

related: #1655

@Oaphi Oaphi changed the title setting up ERB linting Add ERB linting to the project Jul 24, 2025
@codecov

codecov Bot commented Jul 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.10%. Comparing base (1ab1ddf) to head (5a1d4ba).

⚠️ Current head 5a1d4ba differs from pull request most recent head 56c7a06

Please upload reports for the commit 56c7a06 to get more accurate results.

Additional details and impacted files
Components Coverage Δ
controllers 76.98% <ø> (ø)
helpers 85.47% <ø> (ø)
jobs 77.43% <ø> (ø)
models 93.25% <ø> (ø)
tasks 61.11% <ø> (ø)
scripts ∅ <ø> (∅)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oaphi
Oaphi force-pushed the 0valt/1699/erb_lint branch from cec0b23 to 05c1531 Compare July 24, 2025 09:05
@Oaphi
Oaphi force-pushed the 0valt/1699/erb_lint branch from c8d57fd to 9763d01 Compare July 24, 2025 12:04
@Oaphi

This comment was marked as outdated.

@Oaphi
Oaphi force-pushed the 0valt/1699/erb_lint branch from 3c51014 to 13feab8 Compare August 21, 2026 23:59
@Oaphi
Oaphi force-pushed the 0valt/1699/erb_lint branch 5 times, most recently from 5a1d4ba to aa702d2 Compare August 22, 2026 11:21
@Oaphi
Oaphi force-pushed the 0valt/1699/erb_lint branch from aa702d2 to 8356551 Compare August 22, 2026 11:21
@Oaphi

Oaphi commented Aug 22, 2026

Copy link
Copy Markdown
Member Author

Had to basically restart the PR in case anyone's wondering what are all those force-pushes about.
We have around ~570 true positives reported. This PR tends to fall behind quickly, so I am changing my approach here - it's going to just sit there and have updates from develop merged in. Any changes actually fixing the reported issues should be made as standalone PRs or as part of working on other issues.

Blocking the whol linting until we settle on the style seems
unreasonable
@Oaphi

Oaphi commented Aug 22, 2026

Copy link
Copy Markdown
Member Author

Collaboration welcome - if anyone is up to taking on a chunk or two, it'll be appreciated (just avoid simply running autocorrect - I can do that myself just fine, prefer harder problems reported). Please take note of PRs linked here so as not to duplicate work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add HTML/ERB linting

2 participants