fix: publish-npm workflow builds invalid JSON on manual dispatch - #87
Open
BhariGowda wants to merge 1 commit into
Open
fix: publish-npm workflow builds invalid JSON on manual dispatch#87BhariGowda wants to merge 1 commit into
BhariGowda wants to merge 1 commit into
Conversation
The workflow_dispatch path input was embedded via string interpolation:
"{ \"paths_released\": \"\" }"
This produces a string-within-a-string that JSON.parse rejects with
'Expected , or }'. Manual re-publish via the path input always crashes.
Fix: use jq to construct the JSON payload properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
workflow_dispatchpath input was embedded via string interpolation:This produces a string-within-a-string that
JSON.parserejects withExpected ',' or '}'. Manual re-publish via the path input always crashes — verified against all three input cases (empty,.,packages/mcp-server).Fix: use
jqto construct the JSON payload properly.Testing: Verified the new command produces valid JSON for all three dispatch paths.