Skip to content

fix(front): dedupe gitlab commit notifications by event id #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timosaikkonen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(front): dedupe gitlab commit notifications by event id #320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/routes/(app)/dashboard/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,8 @@
return 'note' in n && n.note.noteable_id?.toString() === item.id;
case !!n.target_id:
return 'target_id' in n && n.target_id?.toString() === item.id;
case 'push_data' in n:
return !('push_data' in n && n.push_data.ref === item.ref);
default:
// Push/commit events (and anything else) are keyed by their event id
return item.id === n.id?.toString();
}
});
Expand Down
Loading