fix: never resolve derived characteristic types by uuid - #148
Open
bobby-smedley wants to merge 1 commit into
Open
bobby-smedley wants to merge 1 commit into
bobby-smedley wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What does this PR do?
The skip guard in both assignment parsers matched only DerivedRelationType. DerivedAttributeType passed it, and then got classified as a normal attribute because the attribute check is a HasSuffix("AttributeType") match (it covers StringAttributeType, DateAttributeType, and so on). So a derived attribute became a writable slot in prepare_create_asset and got resolved via /rest/2.0/attributeTypes/{id} — a lookup the platform stops answering for derived types in 2026.10.
Derived relation types were already excluded as non-creatable in #104 (
04fb4e1); this applies the same rule to derived attribute types, which that PR missed because DATs don't appear in any payload yet.isDerivedDiscriminator().Relation types were already safe. Derived attribute types aren't released yet, so no live impact today.
✅ Checklist