fix(types): reject unrecognized pull_policy values instead of defaulting - #923
Merged
Merged
Conversation
ndeloof
approved these changes
Aug 31, 2026
ndeloof
approved these changes
Aug 31, 2026
An unanchored JSON Schema pattern let typo'd pull_policy values (e.g. "neverxxx") pass validation as substring matches, and GetPullPolicy() silently mapped any unrecognized value to PullPolicyMissing. A one-character typo could therefore silently invert "never" into a registry pull with no diagnostic. Anchor the schema pattern with ^...$ and make GetPullPolicy() return an error for unrecognized values, while still defaulting silently when pull_policy is unset and accepting the bare "refresh" literal already allowed by the schema. Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
glours
force-pushed
the
fix/pull-policy-validation
branch
from
August 31, 2026 15:21
b558c87 to
13499b4
Compare
glours
enabled auto-merge (rebase)
August 31, 2026 15:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unanchored JSON Schema pattern let typo'd pull_policy values (e.g. "neverxxx") pass validation as substring matches, and GetPullPolicy() silently mapped any unrecognized value to PullPolicyMissing. A one-character typo could therefore silently invert "never" into a registry pull with no diagnostic.
Anchor the schema pattern with ^...$ and make GetPullPolicy() return an error for unrecognized values, while still defaulting silently when pull_policy is unset and accepting the bare "refresh" literal already allowed by the schema.
Fixes https://docker.atlassian.net/browse/DDB-665