composefs-boot: Make composefs integration optional - #411
Merged
Merged
Conversation
Allow e.g. bcvk to use the Android boot image and UKI parsers without pulling in the composefs dependency graph. Keep integration enabled by default so existing consumers retain their current APIs. Assisted-by: AI Signed-off-by: Alexander Larsson <alexl@redhat.com>
Contributor
Author
|
I see @cgwalters acked bootc-dev/bcvk#397, so I'm removing the draft here. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The newly supported parser-only feature configuration is not exercised by CI.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Makes composefs integration optional so consumers such as bcvk can use boot-image parsers with minimal dependencies.
Changes:
- Adds default-enabled
composefs-integrationfeature. - Gates composefs-specific modules and dependencies.
- Moves
BootOpsinto a feature-gated module.
| File | Description |
|---|---|
| Cargo.toml | Preserves default features for workspace consumers. |
| crates/composefs-boot/Cargo.toml | Defines feature and optional dependencies. |
| crates/composefs-boot/src/lib.rs | Gates integration APIs. |
| crates/composefs-boot/src/integration.rs | Houses composefs-specific boot transformations. |
| crates/composefs-boot/src/uki.rs | Gates integration-only test helper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| [features] | ||
| default = ["composefs-integration"] | ||
| composefs-integration = ["dep:anyhow", "dep:composefs", "dep:fn-error-context", "dep:pcre2", "dep:regex-automata", "dep:rustix"] |
Collaborator
There was a problem hiding this comment.
Ah yeah, can be a followup though
cgwalters
approved these changes
Oct 2, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow e.g. bcvk to use the Android boot image and UKI parsers without pulling in the composefs dependency graph. Keep integration enabled by default so existing consumers retain their current APIs.
Assisted-by: AI
note: This is a draft proposal for bootc-dev/bcvk#397, whether we want to do this depends on the outcome of that.