Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ls: add --sort-by FIELDS option #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
ls: add --sort-by FIELDS option #434
Changes from all commits
34202ba75802757d69807055b98e496e92fFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot add also parametrization of sort_by for each possible one as in
LS_FIELD_CHOICES, and ensure that it works correctlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Added
test_ls_sort_by_each_fieldparametrized over all 31LS_FIELD_CHOICES. Each case creates 3 runs with deliberately non-sorted values for the sort field, then asserts the output is in the correct sorted order.Also fixed a pre-existing bug in the sort key: fields that hold a
listordict(e.g.gpu) would raiseTypeErrorduring comparison. The new_make_sort_valuehelper serialises those to a JSON string before sorting, giving a stable deterministic order without crashing.