Conversation
Individual event names already accept surrounding whitespace, but group shorthands are matched before trimming. Normalize each token before both lookups so comma-separated input such as pod, container works in API consumers and the logger plugin. Assisted-by: OpenAI Codex Signed-off-by: xinjun.jiang <xinjun.jiang@daocloud.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseEventMask("pod, container")rejects" container", although surrounding whitespace is already accepted for individual event names. This also makes the logger plugin fail to start with-events 'pod, container'.Trim each comma-separated token before matching the
all,pod,podsandbox, andcontainershorthands. Tests cover surrounding whitespace, combined groups, existing individual-event behavior, and rejection of unknown events.Validation: five new cases failed before the change.
make test build-check,go test -race ./pkg/api, and the CI-pinned golangci-lint v2.12.0 pass. The real logger binary previously exited during event parsing; after the fix it constructs the plugin with the expected event subscriptions and reaches the connection attempt against an intentionally absent NRI socket. No runtime integration or live container hooks were exercised.AI assistance: OpenAI Codex helped prepare the change and regression tests; the diff and local validation were reviewed.