go fix, minor linting fixes, and simplify Windows compatibility release lookup - #37
Open
thaJeztah wants to merge 2 commits into
Open
go fix, minor linting fixes, and simplify Windows compatibility release lookup#37thaJeztah wants to merge 2 commits into
thaJeztah wants to merge 2 commits into
Conversation
Use slices.Backward, as suggested by go fix, to iterate over LTSC releases in reverse order. Default the compatibility floor to the first release and update it only when the matching release has a predecessor. Adjust the comments to describe the fallback. Compatibility behavior is unchanged. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use slices.Backward, as suggested by go fix, to iterate over LTSC releases in reverse order.
Default the compatibility floor to the first release and update it only when the matching release has a predecessor. Adjust the comments to describe the fallback. Compatibility behavior is unchanged.