Skip to content

fix false positive hardcoded secrets issues #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshitha07d merged 2 commits into from
Aug 10, 2026
Merged

fix false positive hardcoded secrets issues #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e328552
fix false positive hardcoded secrets issues
harshithad0703 Aug 10, 2026
74ec027
ci: grant checks and pull-requests write permissions to coverage job
harshithad0703 Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ on:
jobs:
coverage:
runs-on: ubuntu-latest
permissions:
contents: read
checks: write
pull-requests: write
steps:
- uses: actions/checkout@v3
- uses: ArtiomTr/jest-coverage-report-action@v2
Expand Down
4 changes: 4 additions & 0 deletions test/contentstack-core.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ describe('contentstackCore', () => {
it('should include apiKey in headers when provided', () => {
const options = {
apiKey: 'my-api-key',
// deepcode ignore HardcodedNonCryptoSecret: test fixture value, not a real secret
accessToken: 'my-access-token',
insecure: true,
defaultHostname: 'example.com',
Expand All @@ -117,6 +118,7 @@ describe('contentstackCore', () => {
expect(instance.defaults.headers).toEqual(
expect.objectContaining({
api_key: 'my-api-key',
// deepcode ignore HardcodedNonCryptoSecret: test fixture value, not a real secret
access_token: 'my-access-token',
})
);
Expand All @@ -125,6 +127,7 @@ describe('contentstackCore', () => {
it('should include accessToken in headers when provided', () => {
const options = {
apiKey: 'my-api-key',
// deepcode ignore HardcodedNonCryptoSecret: test fixture value, not a real secret
accessToken: 'my-access-token',
insecure: false,
defaultHostname: 'example.com',
Expand All @@ -138,6 +141,7 @@ describe('contentstackCore', () => {
expect(instance.defaults.headers).toEqual(
expect.objectContaining({
api_key: 'my-api-key',
// deepcode ignore HardcodedNonCryptoSecret: test fixture value, not a real secret
access_token: 'my-access-token',
})
);
Expand Down
2 changes: 2 additions & 0 deletions test/contentstack-error.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ describe('Contentstack Error', () => {
data: {
name: 'John Doe',
email: 'johndoe@example.com',
// deepcode ignore NoHardcodedPasswords: test fixture value, not a real secret
password: 'password123',
},
headers: {
Expand Down Expand Up @@ -92,6 +93,7 @@ describe('Contentstack Error', () => {
data: {
name: "John Doe",
email: "johndoe@example.com",
// deepcode ignore NoHardcodedPasswords: test fixture value, not a real secret
password: "password123",
},
headers: {
Expand Down
1 change: 1 addition & 0 deletions test/request.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ describe('Request tests', () => {

client.stackConfig = {
// live_preview not defined
// deepcode ignore HardcodedNonCryptoSecret: test fixture value, not a real secret
apiKey: 'test-key',
};

Expand Down
3 changes: 3 additions & 0 deletions test/utils/mocks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const mockErrorResponse = {
data: {
name: "John Doe",
email: "johndoe@example.com",
// deepcode ignore NoHardcodedPasswords: test fixture value, not a real secret
password: "password123",
},
headers: {
Expand Down Expand Up @@ -36,6 +37,7 @@ const mockErrorResponseWithoutErrorData = {
data: {
name: "John Doe",
email: "johndoe@example.com",
// deepcode ignore NoHardcodedPasswords: test fixture value, not a real secret
password: "password123",
},
headers: {
Expand Down Expand Up @@ -70,6 +72,7 @@ const mockErrorResponseNoData = {
data: {
name: "John Doe",
email: "johndoe@example.com",
// deepcode ignore NoHardcodedPasswords: test fixture value, not a real secret
password: "password123",
},
headers: {
Expand Down
Loading