Dev - #1151
Merged
Merged
Dev#1151
Conversation
…d objects in drupal
…sets extractAssets only read formal wp:post_type=attachment items, so images embedded in post content (no attachment item backing them) never got a row on the Map Entry Assets screen, even though the actual migration downloads and creates them as real Contentstack assets via wordpress.service.ts's content:encoded scan. Extends extraction to find those images too, matching the id scheme the real migration uses so uids still resolve, and dedupes against formal attachment items so an overlapping URL doesn't get two rows.
Editing the file path after selecting a CMS with a single fixed allowed format (e.g. Sitecore, always Zip) re-derived the displayed "File Format" from the new path's extension, showing e.g. "XML" instead of staying "Zip". Only CMS types with more than one allowed format (currently just stack-to-stack Contentstack) should have the label follow the actual uploaded extension; everyone else keeps their fixed format, with the existing validation effect flagging a real mismatch instead.
- extractAssets.ts: cover a[href] image links, audio/source, and CSS background-image (inline + <style>), not just img src/data-src/srcset, so the same set of embedded assets the real migration finds also get a row. Also: skip relative URLs when wp:base_site_url is missing instead of emitting a row for an asset the run can't actually resolve. - LoadFileFormat.tsx: lock the displayed format only when the CMS has exactly one allowed format. An empty allowed_file_formats (CMS not yet resolved, e.g. Sitecore before a version is picked) now correctly falls through to the extension-derived display instead of blanking the field.
…e-value fields correctly
Delta Migration | 1.0.0 | In Drupal Assets are not getting attached to entries
Bugfix/cmg 1109 1004 fixes
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
Consider reviewing these vulnerabilities when fixes become available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Jira Ticket
MIGRATION-XXXX
📋 PR Type
📝 Description
What changed?
Why?
🧩 Affected Areas
api— Node.js backendui— React frontendupload-api— Upload API serverdocker/docker-compose🧪 How to Test
Expected result:
📸 Screenshots / Recordings
🔗 Related PRs / Dependencies
✅ Author Checklist
feature/,bugfix/, orhotfix/+ 5–30 lowercase chars.env/example.envupdated if new environment variables were addednpm test)README.md/ docs updated if behaviour changed👀 Reviewer Notes