Repository navigation
feat(server): add --force and --delete-from-provider flags to remove - #98
Merged
Merged
Conversation
Pass force and delete_from_provider query parameters when deleting a server, allowing removal of all resources on the server and deletion of the server from its cloud provider (Hetzner, Vultr or DigitalOcean). Update service tests to cover all flag combinations and document the new flags in llms-full.txt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--forceflag tocoolify server remove. It also deletes every resource on the server.--delete-from-providerflag tocoolify server remove. It also deletes the server from its cloud provider (Hetzner, Vultr or DigitalOcean). This cannot be undone.false, so running the command without them works the same as before. The CLI now always sendsforceanddelete_from_provideras query parameters onDELETE /api/v1/servers/{uuid}.llms-full.txtto document the new parameters.Deletetests now cover all four flag combinations.Breaking Changes
ServerService.Deleteininternal/servicenow takes two more arguments,forceanddeleteFromProvider. The CLI command is still backward compatible.