Skip to content

fix(dev): support cross-device Electron cache setup - #2380

Merged
jonathanKingston merged 1 commit into
mainfrom
codex/fix-electron-cache-cross-device
Sep 9, 2026
Merged

fix(dev): support cross-device Electron cache setup#2380
jonathanKingston merged 1 commit into
mainfrom
codex/fix-electron-cache-cross-device

Conversation

@jonathanKingston

Copy link
Copy Markdown
Collaborator

Summary

  • fall back to a staged recursive copy when promoting Electron's extracted dist returns EXDEV
  • keep the destination atomic by copying beside the shared cache and renaming only after completion
  • preserve the source and clean incomplete staging directories when copying fails

Validation

  • pnpm test -- move-directory dev-bundle-path agent-service roadmap-issue-import provider-selection
  • pnpm run check (8,547 tests passed)

github-actions Bot added a commit that referenced this pull request Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

🖥️ PR preview

@jonathanKingston

Copy link
Copy Markdown
Collaborator Author

Validation follow-up (2026-09-05): re-reviewed this diff against the current origin/main. The direct rename remains the fast path; only EXDEV falls back to destination-side staging, the staging directory is promoted atomically, the source is removed only after promotion, and failed copies retain the source while cleaning staging. The PR is mergeable and every required CI check is green. No further changes needed.

@jonathanKingston
jonathanKingston force-pushed the codex/fix-electron-cache-cross-device branch from 4445b8c to 3f65aa3 Compare September 6, 2026 09:19
github-actions Bot added a commit that referenced this pull request Sep 6, 2026
@jonathanKingston
jonathanKingston merged commit 9067078 into main Sep 9, 2026
15 of 16 checks passed
@jonathanKingston
jonathanKingston deleted the codex/fix-electron-cache-cross-device branch September 9, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant