test(exec): allow loaded runners to observe background exit - #2386
Merged
Merged
Conversation
Collaborator
Author
|
Validation follow-up (2026-09-05): the focused background-process suite passed 19/19 and the complete local |
jonathanKingston
force-pushed
the
codex/stabilize-background-process-test
branch
from
September 6, 2026 09:19
106fecd to
a7787cf
Compare
Contributor
🖥️ PR preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The background-process manager tests poll for a short-lived child to exit. The helper's five-second deadlock guard can expire during the full parallel suite when a busy runner delays scheduling the new Node child, even though the process and manager are working correctly. The test passes in isolation.
Fix
No product timeout or background-process behavior changes.
Validation
pnpm test -- src/main/services/exec/background-process.test.ts(19/19)pnpm run check(8,543/8,543 tests; typecheck, lint, format, site, dead-code, oracle, and E2E syntax checks all green)