Skip to content

test(exec): allow loaded runners to observe background exit - #2386

Merged
jonathanKingston merged 1 commit into
mainfrom
codex/stabilize-background-process-test
Sep 9, 2026
Merged

jonathanKingston merged 1 commit into
mainfrom
codex/stabilize-background-process-test

Conversation

@jonathanKingston

Copy link
Copy Markdown
Collaborator

Problem

The background-process manager tests poll for a short-lived child to exit. The helper's five-second deadlock guard can expire during the full parallel suite when a busy runner delays scheduling the new Node child, even though the process and manager are working correctly. The test passes in isolation.

Fix

  • Raise only the test helper's deadlock guard from 5 seconds to 30 seconds.
  • Keep the 20 ms polling interval, so ordinary successful runs still finish immediately.
  • Document why the larger outer guard is necessary under full-suite load.

No product timeout or background-process behavior changes.

Validation

  • pnpm test -- src/main/services/exec/background-process.test.ts (19/19)
  • pnpm run check (8,543/8,543 tests; typecheck, lint, format, site, dead-code, oracle, and E2E syntax checks all green)

@jonathanKingston

Copy link
Copy Markdown
Collaborator Author

Validation follow-up (2026-09-05): the focused background-process suite passed 19/19 and the complete local pnpm run check passed 8,543/8,543 under the same parallel load that exposed the five-second guard. GitHub CI is also fully green. This changes only the test helper's deadlock guard; successful polling and product timeouts remain unchanged. No further changes needed.

@jonathanKingston
jonathanKingston force-pushed the codex/stabilize-background-process-test branch from 106fecd to a7787cf Compare September 6, 2026 09:19
github-actions Bot added a commit that referenced this pull request Sep 6, 2026
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

🖥️ PR preview

@jonathanKingston
jonathanKingston merged commit 0578170 into main Sep 9, 2026
15 of 16 checks passed
@jonathanKingston
jonathanKingston deleted the codex/stabilize-background-process-test branch September 9, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant