Skip to content

fix(search): report failed searches instead of false misses - #2582

Merged
jonathanKingston merged 1 commit into
mainfrom
codex/report-search-failures
Sep 9, 2026
Merged

jonathanKingston merged 1 commit into
mainfrom
codex/report-search-failures

Conversation

@jonathanKingston

Copy link
Copy Markdown
Collaborator

A ripgrep or grep error currently becomes “No matches found.” Invalid regexes and unreadable search roots can therefore make the agent conclude relevant code does not exist.

Propagate unsuccessful command exits with the diagnostic message, while preserving exit code 1 as a valid empty search. Regression coverage distinguishes a regex failure from a legitimate miss.

Validation: pnpm run check. The error regression fails on current main. Uses the existing tool-error presentation; no DOM or layout changes.

github-actions Bot added a commit that referenced this pull request Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🖥️ PR preview

@jonathanKingston
jonathanKingston merged commit f63bd9a into main Sep 9, 2026
23 checks passed
@jonathanKingston
jonathanKingston deleted the codex/report-search-failures branch September 9, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant