fix(files): stop writes when reading existing content fails - #2584
Merged
Merged
Conversation
Contributor
🖥️ PR preview
|
Contributor
Reference screenshots ready for reviewReview GitHub’s image diffs in screenshot PR #2586. Rendered for If this source branch moves, a later successful render closes the stale review PR and replaces this link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_fileand approval-time writes currently treat every read failure as an empty/missing file. If an existing local file cannot be read, its contents can be overwritten without the stale-content guard checking them.Only a missing-file error may take the new-file path. Other errors stop the tool or return an apply error before writing. Regression tests inject EACCES and EIO and verify the existing bytes survive; existing new-file tests cover the permitted path.
Validation:
pnpm run check. Both read-failure regressions fail on current main. File I/O handling only; approval policy, hooks, DOM, and layout are unchanged.