Skip to content

refactor(container): report lifecycle phases as structured events - #2599

Merged
jonathanKingston merged 1 commit into
claude/copse-container-execution-nw4ln8from
codex/container-phase-events
Sep 9, 2026
Merged

jonathanKingston merged 1 commit into
claude/copse-container-execution-nw4ln8from
codex/container-phase-events

Conversation

@jonathanKingston

@jonathanKingston jonathanKingston commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Container lifecycle state depended on matching human-readable diagnostic strings. Replace those matches with typed worker phase records, decoded at the pipe boundary and forwarded through an explicit runner callback. Ordinary logs no longer advance state, and the guest cannot declare a terminal outcome.

Follow-up to #2348, targeting its feature branch so this PR contains only the phase change. Also validated in an isolated checkout rebased onto origin/main at 4253dfd0f.

Validation: typecheck, lint, formatting, dead-code, oracle, and e2e-syntax checks passed; 48 focused tests passed, including split pipe writes and malformed/terminal records. The full sandboxed suite reported 8,824 passing, 42 failing, 41 cancelled, and 9 skipped tests; failures include denied loopback/Unix socket listeners (EPERM). Existing phase labels and DOM are unchanged. All four changes were also integrated: 8,953 full-suite unit tests passed outside the sandbox, and the final 208-test targeted regression run passed after the additional cancellation fix.

@jonathanKingston
jonathanKingston force-pushed the codex/container-phase-events branch from 866ac5a to d55da93 Compare September 9, 2026 01:56
github-actions Bot added a commit that referenced this pull request Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

🖥️ PR preview

@jonathanKingston
jonathanKingston marked this pull request as ready for review September 9, 2026 02:53
@jonathanKingston
jonathanKingston merged commit 9b1bd3b into claude/copse-container-execution-nw4ln8 Sep 9, 2026
34 checks passed
@jonathanKingston
jonathanKingston deleted the codex/container-phase-events branch September 9, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant