Skip to content

refactor(container): track external runs with the task supervisor - #2603

Merged
jonathanKingston merged 2 commits into
claude/copse-container-execution-nw4ln8from
codex/supervise-container-runs
Sep 9, 2026
Merged

jonathanKingston merged 2 commits into
claude/copse-container-execution-nw4ln8from
codex/supervise-container-runs

Conversation

@jonathanKingston

@jonathanKingston jonathanKingston commented Sep 9, 2026 •

Copy link
Copy Markdown
Collaborator

Container runs had separate, session-only lifecycle ownership. Register them as external tasks with the existing supervisor before image preparation, persist ownership and terminal outcomes, route cancellation through its external canceller, and cancel live runs during app shutdown. One AbortController replaces the separate stop-request ledger, including stops during checkout preparation.

Docker execution, attestation, credentials, egress, carry-out and runtime budget enforcement remain in the runner. External task adoption does not enforce queued-handler concurrency limits. Lost runtime handles fail on restart; no handler replays the run and explicit continuation remains required. Prompts and credentials are not stored in supervisor metadata.

Follow-up to #2348, targeting its feature branch. Contract documented in docs/plans/thread-in-container.md.

Validation: 61 focused lifecycle/reconciliation tests passed; the final 34-test service run also passed, including the regression for starting a new run while the previous outcome is still being saved; all 207 combined regression tests passed outside the sandbox. Typecheck, lint, formatting and dead-code checks passed in an isolated checkout rebased onto origin/main at 4253dfd0f; all static check stages passed. The integrated full unit suite passed 8,953 tests outside the sandbox, and the final targeted run passed all 208 tests after adding the cancellation regression. Redundant sandboxed full-suite runs were stopped. Build passed. Focused Electron e2e (container-supervised-task.e2e.ts) passed; screenshot inspected: readable container task label, blocked state and cancel action in the Background tasks rail, then row removal after cancellation. Screenshot included.

github-actions Bot added a commit that referenced this pull request Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

🖥️ PR preview

@jonathanKingston
jonathanKingston marked this pull request as ready for review September 9, 2026 02:53
@jonathanKingston
jonathanKingston merged commit 399e114 into claude/copse-container-execution-nw4ln8 Sep 9, 2026
35 checks passed
@jonathanKingston
jonathanKingston deleted the codex/supervise-container-runs branch September 9, 2026 03:14

This branch was previously deployed

1 inactive deployment
github-pages — 620596ac Deployed Sep 9, 2026 by github-actions[bot] via deploy #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant