Fix callout glyphs in forced colors and correct prototype guidance - #2605
Merged
Merged
Conversation
Contributor
Reference screenshots ready for reviewReview GitHub’s image diffs in screenshot PR #2612. Rendered for If this source branch moves, a later successful render closes the stale review PR and replaces this link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In forced-colors mode, the five callout mask backgrounds introduced by #2404 were repainted to the same color as their plate, hiding the glyphs. Use system
CanvasTextand disable automatic color adjustment only on the glyph pseudo-element, leaving the rest of each callout responsive to the user's palette.Add a regression that fails on the previous implementation and passes in both dark and light forced-colors palettes. Cover reduced-transparency and increased-contrast hatch fallbacks, and include five focused screenshots for the forced-colors callouts and expanded Thinking states.
Correct the prototype and UI guidance to describe the actual numeric tuning tokens, per-component severity mixing, standing-proposal rail exception and VNC gutter sizes. Remove the incorrect claim that an 8px diagonal hatch guarantees freedom from aliasing. The prototype remains an archive; a living guide built from production components is a separate follow-up, as are custom-accent collisions and exact VNC gutter alignment.
Validation
pnpm run checkstages passed before rebasing onto main: typecheck, lint, formatting, demo sync, dead-code, oracle, e2e syntax and 8,751 unit tests. One formatting failure was corrected, then the remaining stages were resumed.