kola: stop treating scos and rhcos as the same distro#4580
kola: stop treating scos and rhcos as the same distro#4580nikita-dubrovskii wants to merge 3 commits into
Conversation
Despite SCOS and RHCOS being largely similar, we want to limit some tests (like iso.iso-fips) for RHCOS only.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request decouples the "scos" distribution from "rhcos" in the test suite, allowing it to be treated as its own distinct distribution rather than mapping it to "rhcos". This change updates numerous tests to explicitly include or exclude "scos" alongside "rhcos". A typo was identified in mantle/kola/tests/fips/hmac.go where "scsos" was written instead of "scos".
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Previously, SCOS was treated as RHCOS and these tests ran on SCOS. After separating SCOS as a distinct distro, explicitly add SCOS to tests compatible with both distributions while keeping some tests (like iso.iso-fips) RHCOS-only.
nikita-dubrovskii
force-pushed
the
separate_rhcos_scos
branch
from
1419445 to
82c1660
Compare
dustymabe
left a comment
dustymabe
left a comment
There was a problem hiding this comment.
LGTM - can we get the commit message on the one commit updated?
There was a problem hiding this comment.
I know it feels redundant, but I really like having there at least be a sentence for the body of a commit message.
This function isn't used anywhere so we can delete it.
2 participants
Despite SCOS and RHCOS being largely similar, we want to limit some tests (like iso.iso-fips) for RHCOS only.
Issue: #4555