Skip to content

fix: strip leading v from release tag before passing to uv version - #127

Closed
fzipi with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-only-review-comment
Closed

fzipi with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-only-review-comment

Conversation

Copilot AI commented Jun 7, 2026 •

Copy link
Copy Markdown

Release tags in this repo use a v prefix (e.g., v0.2.4). Passing github.ref_name directly to uv version sets an invalid PEP 440 version, which would cause the publish workflow to fail.

Changes

  • .github/workflows/pypi-release.yml: Use bash parameter expansion to strip the leading v before calling uv version:
- uv version "$RELEASE_VERSION"
+ uv version "${RELEASE_VERSION#v}"

This ensures tags like v0.2.4 are normalised to 0.2.4 before the version is set and the package is built.

fzipi and others added 2 commits June 7, 2026 12:09
Convert dependency management and build tooling from Poetry to uv:

- pyproject.toml: Poetry tables -> PEP 621 [project] and
  [dependency-groups]; build backend poetry-core -> uv_build.
  Drop deprecated license classifier in favor of
  license = "Apache-2.0" (PEP 639).
- Drop the setuptools dependency: it was only needed by older textX
  (via pkg_resources). textX 4.3 uses importlib.metadata, so neither
  the runtime dep nor the dev pin is required.
- Replace poetry.lock with uv.lock.
- CI: use astral-sh/setup-uv; uv sync / uv run in tests; uv build,
  uv version, and uv publish (PyPI OIDC trusted publishing) on
  release. Harden workflows (persist-credentials: false, disable
  cache, env var for github.ref_name).
- Docs: update README.md to uv commands.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI changed the title [WIP] Fix code based on review comment fix: strip leading v from release tag before passing to uv version Jun 7, 2026
Copilot finished work on behalf of fzipi June 7, 2026 15:42
Copilot AI requested a review from fzipi June 7, 2026 15:42
@fzipi
fzipi marked this pull request as ready for review June 7, 2026 15:44
@fzipi fzipi closed this Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants