Add typed merge and rebase recovery commands#71
Conversation
Review findings
|
|
Addressed both posted review findings in commit
Verification (all passed):
|
|
Fresh independent review found zero concerns. Reviewed the complete PR diff and commit history against issue #54, relevant Git operation-state and command-execution code, temporary-repository tests, existing PR feedback, and CI status. I specifically checked correctness and data-loss risks around merge/rebase continue, abort, skip, rebase-merges nested merge state, mismatched/absent operation rejection, editor suppression, hook/signing preservation, non-UTF-8 hook output, and next-conflict reporting. Local verification passed:
|
Review finding
Local verification on |
|
Addressed the non-UTF-8 failed-recovery finding in commit
Verification (all passed):
|
|
Fresh independent review of current head Reviewed the complete diff and commit history against issue #54, surrounding Git operation-state and process-execution code, temporary-repository tests, output/error handling, and current checks. Verified correctness, Git semantics, data-loss and race risks, security, hooks/signing, editor suppression, nested rebase-merge state, non-UTF-8 output, and missing-test risk. Local verification passed:
CI checks are green. |
Summary
Verification
cargo fmt --all --checkcargo clippy --locked --workspace --all-targets -- -D warningscargo test --locked --workspaceFixes #54