-
Notifications
You must be signed in to change notification settings - Fork 31
feat(i18n): deterministic integrity/typography checks and real per-language style guides #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Timur Tukaev (tym83)
wants to merge
17
commits into
feat/i18n-pipeline
Choose a base branch
from
feat/i18n-quality-improvements
base: feat/i18n-pipeline
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,442
−58
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
df69675
feat(i18n): guarantee link/identifier integrity and check typography
tym83 97dd5fc
docs(i18n): turn the per-language style guides into real contracts
tym83 c2ba45e
fix(i18n): resolve the number-formatting contradiction in the transla…
tym83 41255d0
fix(i18n): mask raw HTML and never regenerate hand-localized pages
tym83 a9af5f3
fix(i18n): never nest masking placeholders and unwind nesting on restore
lexfrei 48f87fc
fix(i18n): stop the deterministic checks contradicting the style guides
lexfrei 8d1f8c1
fix(i18n): refuse to overwrite a hand-localized page with machine output
lexfrei 9a5a6f8
docs(i18n): document the deterministic checks stage and the typograph…
lexfrei d91a70a
ci(i18n): run the typography lint as an advisory step
lexfrei 435ef0b
fix(i18n): stop flagging the style guides' own canonical examples
lexfrei d5d898d
fix(i18n): keep reporting hand-localized drift on an empty worklist
lexfrei dab8ee1
fix(i18n): keep the hand-localized drift signal alive across CI tooling
lexfrei c86b7d2
fix(i18n): treat the markdown image marker as syntax, not prose
lexfrei c70b20d
fix(i18n): exit 0 from update-digests when no stamped translations exist
lexfrei 72fc0ae
fix(i18n): keep link-title quotes out of the prose checks
lexfrei 345f998
fix(i18n): warn instead of claiming success when a page has no digest…
lexfrei 005aa46
fix(i18n): reject placeholder tokens the model was never sent
tym83 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error path knows nothing about translation scope, and that turns old translations into CI blocker. Any
l10n: mtpage with drifted digest fails the lint, lint runs on every PR touchingcontent/**, but the pipeline only refreshes the latest version, socontent/*/docs/v1.4/getting-started/_index.mdcannot be fixed by rerunning it.Digests match right now, I checked all four languages on main, so nothing is red yet. It goes red as soon as the upstream tags workflow pushes
make update-all RELEASE_TAG=v1.4.xintocontent/en/docs/v1.4/, and from that moment every PR in this repo is blocked until somebody translates that page by hand or deletes it. Either downgrade out of scope pages to warning like transcreate ones, or remove them.