fix(common): handle undefined error in sendError - #1743
Merged
Merged
Conversation
Guard all error dereferences in sendError so an undefined argument does not throw a TypeError before the 500 fallback. Add a regression test for service.sendError(undefined). Addresses CodeRabbit feedback on #1742. Signed-off-by: Ajay Jadhav <ajay@ayanworks.com>
|
Warning Review limit reachedNext included review available in 27 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Addresses CodeRabbit feedback on #1742.
sendError()takesanyandhttpPut()passes its caught rejection straight through, sosendError(undefined)was reachable. It crashed with aTypeErrorbecause:error.response?.statusbefore any guardifcondition dereferencederror.responsedirectlyerror.messagedirectlyFix
libs/common/src/common.service.ts: guard all three dereferences with optional chaining (error?.response?.status,error?.response?.data,error?.message). Behavior for defined errors is unchanged.Test
falls back to 500 when passed undefinedtocommon.service.spec.tscoveringservice.sendError(undefined).Verification
common.service.spec.ts+http-client.integration.spec.ts: 28 tests passingjest.ci.config.js): 18 suites / 234 tests passingSigned-off-bytrailer