fix(render): resolve xcrd import conflict#104
Conversation
PR#61 removed the xcrd import from `render/xr/cmd.go` by moving the XRD logic into `pkg/xr`. Meanwhile, PR#82 added composed resource sorting reintroducing the dependency. This commit sets a new constant from `pkg.xr` which already imports `xcrd` so that the render command only depends on `pkg/xr` (`xrpkg`). Signed-off-by: Theo Chatzimichos <tampakrap@gmail.com>
|
Warning Review limit reached
More reviews will be available in 40 minutes and 14 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Description of your changes
PR#61 removed the xcrd import from
render/xr/cmd.goby moving the XRD logic intopkg/xr. Meanwhile, PR#82 added composed resource sorting reintroducing the dependency.This commit sets a new constant from
pkg.xrwhich already importsxcrdso that the render command only depends onpkg/xr(xrpkg).I have:
./nix.sh flake checkto ensure this PR is ready for review.Added or updated unit tests.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.