Allow require_resources to match all resources of a kind#213
Merged
Conversation
require_resources rejected a selector with neither match_name nor match_labels set. Crossplane now treats such a selector as matching all resources of the given apiVersion and kind (crossplane/crossplane#7241). This change relaxes the validation to only reject match_name and match_labels both being set. Signed-off-by: Nic Cope <nicc@rk0n.org>
jbw976
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
require_resourcesrejected a selector with neithermatch_namenormatch_labelsset. Crossplane now treats such a selector as matching all resources of the givenapiVersionandkind(crossplane/crossplane#7241).This PR relaxes the validation to only reject
match_nameandmatch_labelsboth being set.I have: