parallel sets: fix XML-invalid characters in set names - #1356
Merged
Conversation
Set names with spaces or other XML-special characters caused a parser error on startup when used as XML tag names (e.g. 'Short set' became <parallel_set_Short set> which is invalid XML). Fix: automatically convert spaces to underscores when storing set names as XML keys, and convert back for display in the UI. New helpers in settings.c: name_to_key(name) - convert display name to XML key (space -> _) key_to_name(key) - convert XML key to display name (_ -> space) Fixes crash on startup when a parallel set name contains a space.
Contributor
|
FYI I did an adjustment to convert your fprintf to XI_message. Thanx. This is a very good feature. |
Contributor
Contributor
Author
|
Ok I'm working on it. If you wouldn't mind, could you check if the other PR is okay and merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Set names with spaces or other XML-special characters caused a parser error on startup when used as XML tag names (e.g. 'Short set' became <parallel_set_Short set> which is invalid XML).
Fix: automatically convert spaces to underscores when storing set names as XML keys, and convert back for display in the UI.
New helpers in settings.c:
name_to_key(name) - convert display name to XML key (space -> )
key_to_name(key) - convert XML key to display name ( -> space)
Fixes crash on startup when a parallel set name contains a space.