Spectrogram support - #82
Draft
NavigSB wants to merge 24 commits into
Draft
Conversation
…, stop trimming in drawSeismograms for better math
… remove units label
…nk of the functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
So, I finally gave the ol' spectrogram a try! Thanks a bunch @bclswl0827 for the huge headstart with the spectrogram-js code! My implementation extends
Seismographto piggyback off of the time and configuration functionality to hopefully ensure consistent behavior for the present and future. If this is a bad idea Philip, let me know and we can figure out another way to do it.TODO: Add a picture of Tutorial 2 with a spectrogram
Scope
What's changed:
SpectrogramConfigclass, extendingSeismographConfigby adding some important configuration optionsSpectrogramclass, inheriting functionality fromSeismographdrawSeismogramsfor custom spectrogram outputcreateLeftRightAxisfor the right y-axis scalecreateUnitsLabelto output "Hz" as the axis unit ifySublabelIsUnitsis trueseisDataUpdatedto clear the image cache when data is updatedPotential Risks / Drawbacks
Tested Scenarios
Review Notes / Questions
Checklist
TODO: Whoops, forgot to add tests. Need to make some before this is ready