Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161.
Allow()stores the redirect target incaptcha_<ip>on every captcha response, so a background request (service worker update, fetch) that comes before the form is posted overwrites the page the visitor navigated to, and the visitor is sent to that background URI after solving the captcha.A request whose
Sec-Fetch-Modeis set and is notnavigatenow keeps the URI of a pending verification. Requests without the header behave as before.Tested in debian:latest as in
nginx.yml: the newt/25_stream_captcha_background_request.tfails on main and passes with the change. The other tests give the same results with and without it; 18, 19, 20 and 24 time out in my container on main as well.