Skip to content

Fix dark mode colors#552

Closed
blaipr wants to merge 4 commits into
ctrliq:mainfrom
blaipr:fix/darkmode-color-regression
Closed

Fix dark mode colors#552
blaipr wants to merge 4 commits into
ctrliq:mainfrom
blaipr:fix/darkmode-color-regression

Conversation

@blaipr

@blaipr blaipr commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • PR Bump postcss-preset-env from 7.8.3 to 11.3.2 #541 (postcss-preset-env bump) included dark mode CSS changes that replaced the original color hierarchy with a uniform #13161b, causing cards, tables, toolbars, and page sections to blend into the background
  • Restored the original values: #000 for page/masthead backgrounds, #1a1e25 for cards/tables/toolbars/pagination, #22262f for thead
  • Kept valid new additions from Bump postcss-preset-env from 7.8.3 to 11.3.2 #541: status label colors, menu-toggle styling, ace tag/markup highlighting, thead border, legend/tooltip backgrounds, wizard sections, polygon transparency

Test plan

  • Dark mode: cards visually separate from page background (black page, dark gray cards)
  • Dark mode: dashboard stat cards and chart card have visible backgrounds
  • Dark mode: table headers distinguishable from table body
  • Light mode: no regressions (file only affects html.pf-v6-theme-dark selectors)

PR ctrliq#541 changed page/card/table/toolbar backgrounds from their
correct values (#000 for pages, #1a1e25 for cards) to a uniform
#13161b, making cards invisible against the page background.
Restore the original color hierarchy and keep the valid new
additions (status label colors, menu-toggle, ace tag/markup,
thead border, legend/tooltip, wizard sections).
@blaipr blaipr changed the title Fix dark mode color regression from postcss-preset-env bump Fix dark mode colors Jun 28, 2026
@cigamit

cigamit commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Seems you pulled in all the changes from my #535. Those were restoring the CSS colors on purpose to move it back to the CIQ themed colors and look (where things blend together). See #351.

@blaipr

blaipr commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

@cigamit Check what I did. I added CtrllQ green on the links, buttons, etc. on both light and dark mode themes under PF6. So the brand "green" is everywhere and now even light mode has rounded buttons, etc.

Your version of the dark theme dropped certain visual elements and made buttons green where buttons were still disabled (e.g. the search icon was green even before writing text to search).

I think this PR's PF6 light & dark css are the correct ones and they look modern and branded :P

@cigamit

cigamit commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

I did check it out. Your changes look like this. With a black masthead and backgrounds.

image

versus the more modern flat look of

image

We are going for the more modern look for dark mode at match the rest of our stack. We can change it up if needed for light mode.
We can tweak button colors and the like, I didn't worry too much about that right now, as a few other areas were broken that needed patching first (Topology View, etc..). Spacing is also changed a bit in areas, and I will work on getting things a bit more compact again. IT Admins generally want to see more data on the screen, not big blank spaces of padding. The need to scroll the screen should be kept to a minimum. That was one the big issues I always had with Patternfly when at RH.

@blaipr

blaipr commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

A few colleagues and I like the version with the black background more - we think it feels more polished. But of course, it's your product and your call ^^

@cigamit

cigamit commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Ya, my UI team wants me to pull in their entire UI suite, and change the icons and everything, but I have pushed back as I don't like the look it gives. What we have now was the compromise.
https://www.npmjs.com/package/@ctrliq/quantic-components

@cigamit cigamit closed this Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants