🔒 fix: prevent XSS in JSON-LD script block#64
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Implement safeJsonLdStringify utility to escape '<' as '\\u003c' in JSON-LD script tags, preventing script tag termination attacks. Apply this utility to the JSON-LD block in the landing page.
amrabed
force-pushed
the
fix/json-ld-xss-vulnerability-18188873139106152267
branch
from
ef887f8 to
d54cf79
Compare
1 participant
🎯 What: Fixed a potential XSS vulnerability in the JSON-LD script block.
⚠️ Risk: Attackers could inject malicious scripts by terminating the JSON-LD script block using
</script>if any field in the JSON-LD was user-controlled or contained malicious content.🛡️ Solution: Implemented a
safeJsonLdStringifyutility that replaces<with its JSON escape sequence\u003c. This ensures that even if the JSON contains</script>, it is rendered as\u003c/script>, which is ignored by the HTML parser as a tag terminator but correctly parsed as part of the JSON data.PR created automatically by Jules for task 18188873139106152267 started by @amrabed