Repository navigation
Run the Windows tests on GitHub-hosted runners - #16
Open
renatoathaydes wants to merge 3 commits into
Open
renatoathaydes wants to merge 3 commits into
renatoathaydes wants to merge 3 commits into
Conversation
e2e-win-full-tests.yaml needed Loft's self-hosted-windows runner, so its job would wait for a runner on every pre-release. GitHub's Windows runners can't run the Linux containers the e2e tests use, so replace it with windows-tests.yaml, which builds the CLI and runs the unit tests on windows-latest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
renatoathaydes
force-pushed
the
ci/windows-runners
branch
from
October 16, 2026 15:10
16fe6e9 to
dc126b2
Compare
addHostSection joins lines with \r\n on Windows, but the test compared against LF-only expectations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e2e-win-full-tests.yamlran onself-hosted-windows, a runner Curity doesn't have. Because it triggers onprereleased, every release would leave its jobs waiting for a runner.Moving it to
windows-latestisn't enough: GitHub's Windows runners only run Windows containers, and the e2e tests (build,ide,ssh,up-docker*) need Linux containers. This PR replaces it withwindows-tests.yaml, which:windows-latest, on pre-releases, on manual dispatch, and on PRs that touch Go codego test ./pkg/... ./cmd/...The Docker e2e tests keep running on Linux in
e2e-tests.yaml.AGENTS.mdand the Unreleased section ofCHANGELOG.mdare updated.Checked locally: the CLI and all test packages cross-compile for
GOOS=windows. This PR's own CI is the first real run on Windows.🤖 Generated with Claude Code