Skip to content

fix(plugins): fail the delete action when no row was removed #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deanrie wants to merge 1 commit into from
Closed

fix(plugins): fail the delete action when no row was removed #443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions apps/cursor/src/actions/delete-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,26 @@ export const deletePluginAction = authActionClient
);
}

const { error } = await supabase
const { data: deleted, error } = await supabase
.from("plugins")
.delete()
.eq("id", id)
.eq("owner_id", userId);
.eq("owner_id", userId)
.select("id");

if (error) {
throw new ActionError(`Failed to delete plugin: ${error.message}`);
}

// A delete that matches no rows is not an error for PostgREST, so without
// this check a row the policy refuses to delete would still produce the
// "Plugin deleted." toast while staying live and keeping its slug.
if (!deleted || deleted.length === 0) {
throw new ActionError(
"The plugin could not be deleted. It is still listed; contact support to have it removed.",
);
}

// Deletions must disappear from cached lists immediately for the owner.
updateTag("plugins");
updateTag(`plugin-${existing.slug}`);
Expand Down