Repository navigation
Conversation
…ingle biome version
|
@deanrie is attempting to deploy a commit to the Anysphere Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Superseded by #450, which carries this commit together with the other housekeeping change as one reviewable PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small hardening items, no behaviour change for valid requests:
cron-auth.ts: the cron secret was compared with!==, which short-circuits on the first differing byte. Switched tocrypto.timingSafeEqualon equal-length buffers (length is checked first, sincetimingSafeEqualthrows on mismatch). The header is read as?? ""so a missing header still returns 401 instead of throwing.ci.yml: addspermissions: contents: read(the default token had write scopes the job never uses) and aconcurrencygroup so a new push cancels the previous run on the same ref.^2.4.15whileapps/cursorpinned2.4.14, sobunx biome ci .could resolve a different binary locally than in CI.apps/cursornow uses2.4.15andbun.lockloses the duplicate 2.4.14 entry.Verification
bun install --frozen-lockfile: no changes.bun x biome ci .: 0 errors (the 5 warnings and 1 info are pre-existing).bun run typecheckinapps/cursor: clean.