Repository navigation
Conversation
|
@deanrie is attempting to deploy a commit to the Anysphere Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Oct 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small fixes on the plugin detail flow, one commit each, consolidated from #443 and #444 (both closed in favour of this PR; commits carried unchanged).
fix(plugins): fail the delete action when no row was removed(was fix(plugins): fail the delete action when no row was removed #443).deletePluginActionran.delete().eq("id", id).eq("owner_id", userId)and only checkederror. PostgREST does not treat a delete that matched zero rows as an error, so when RLS refuses the delete the UI still shows "Plugin deleted.", navigates home, and the listing stays live (the sequence in Delete shows "Plugin deleted." toast but the plugin stays live #413, Plugin delete reports success but the record persists #429, Deleting or unpublishing a plugin returns 200 but the plugin stays published #438). The delete now ends with.select("id")and throws anActionErrorwhen nothing came back, so the owner sees a real error instead of a false success. Which rows the policy allows to delete is unchanged; the stuck listings still need the backend cleanup, this stops the UI from lying about it.fix(plugins): render plugin logos unoptimized so any manifest logo host works(was fix(plugins): render plugin logos unoptimized so any manifest logo host works #444).parse.tsturns a relativelogointo araw.githubusercontent.comURL and keeps absolute logos as submitted, but the detail page rendered them throughnext/image's optimizer, which rejects hosts missing fromimages.remotePatternsand 500s the whole page; every submission followingcursor/plugin-template(relativeassets/logo.svg) hit this, andAGENTS.mddocumented nulling logos in the database as the workaround.PluginLogonow passesunoptimized, matching howPluginCardandPluginLeaderboardalready render the same URLs via plain<img>. TheAGENTS.mdworkaround note is removed.Verification
bun install --frozen-lockfile,bunx biome ci .inapps/cursor: clean (the 5 warnings are pre-existing onmain),bunx tsc --noEmit: clean.Fixes #413, #429, #438 (delete path). Refs #439, #440.