Skip to content

refactor game state request to use socket helper - #1383

Open
ft-sahana wants to merge 1 commit into
cuttle-cards:mainfrom
ft-sahana:fix/request-game-state
Open

ft-sahana wants to merge 1 commit into
cuttle-cards:mainfrom
ft-sahana:fix/request-game-state

Conversation

@ft-sahana

Copy link
Copy Markdown

Issue number

Please check the following

  • Do the tests still pass? (see Run the Tests)
  • Is the code formatted properly? (see Linting (Formatting))
  • For New Features:
    • Have tests been added to cover any new features or fixes?
    • Has the documentation been updated accordingly?

Please describe additional details for testing this change

Refactored requestGameState() to use the shared makeSocketRequest() helper instead of directly calling io.socket.get().

The existing game state handling, reauthentication handling, and resetStateBeforeUpdate behavior have been preserved.

@ft-sahana

Copy link
Copy Markdown
Author

Hi! I’ve submitted the changes for #1229.

The workflow is currently awaiting maintainer approval, so the required checks are still pending. Could someone please approve the workflow when convenient?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DevEx]: refactor gameStore.requestGameState() to use makeSocketRequest() helper

1 participant