CM-72834 show detection shas - #548
Merged
Merged
Conversation
A blocked developer only saw severity counts, so a false positive was unactionable: nothing in the message identified which value tripped the guardrail. List each distinct finding's type and value hash instead, which is what `cycode ignore --by-sha` takes. The hash is safe to display; the value is not. Detections already dropped by an ignore rule are filtered out upstream in create_local_scan_result, so only what actually blocked is listed. The two hook messages that interpolated the summary mid-sentence now put it last, since it spans multiple lines. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
build_violation_summary sat in the shared utils/scan_utils.py but has only ever had one caller, and it is now shaped for a hook message rather than a terminal - multi-line, with a value hash per finding. Other scan commands render through the printers, which already have their own Secret SHA column. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Ilanlido
enabled auto-merge (squash)
September 16, 2026 12:18
omer-roth
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A blocked developer only saw severity counts, so a false positive was unactionable: nothing in the message identified which value tripped the guardrail. List each distinct finding's type and value hash instead, which is what
cycode ignore --by-shatakes.