Add incremental improvements of classier.#3
Merged
Conversation
owlas
suggested changes
May 4, 2017
owlas
left a comment
owlas
left a comment
Contributor
There was a problem hiding this comment.
Additional steps are great. Thanks for spell check too
| "outputs": [], | ||
| "source": [ | ||
| "pipeline.predict([\"Literally just 8 incredible dog videos.\"])" | ||
| "pipeline.predict([\"10 things you need to do...\"])" |
Contributor
There was a problem hiding this comment.
What is the benefit of this? Maybe it wasn't intentional.
Contributor
Author
There was a problem hiding this comment.
The original sentence was labeled as 0 when I switched from title + description into title only :)
| "source": [ | ||
| "df['full_content'] = (df.description + df.title)\n", | ||
| "# df['full_content'] = (df.description + df.title)\n", | ||
| "df['full_content'] = (df.title)\n", |
Contributor
There was a problem hiding this comment.
This is quite confusing. We can just use df.title in the notebook and then switch to df.full_content later to show the incremental benefit.
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "metadata": {}, |
Contributor
There was a problem hiding this comment.
This is model selection based on the testing data!
| "source": [ | ||
| "from sklearn.metrics import accuracy_score\n", | ||
| "from sklearn.metrics import confusion_matrix\n", | ||
| "from utils.plotting import plot_confusion_matrix\n", |
Contributor
There was a problem hiding this comment.
The notebook would be tidier if this was moved into a separate file.
| " ('vectorizer', CountVectorizer()),\n", | ||
| " ('vectorizer', TfidfVectorizer()),\n", | ||
| " ('classifier', LinearSVC())\n", | ||
| ")\n", |
refactor changes for linear nb
owlas
approved these changes
May 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added @matichorvat changes from #2 as well.