Added null-handling when recording host startup exception to current … - #1438
Open
cervengoc wants to merge 1 commit into
Open
Added null-handling when recording host startup exception to current …#1438cervengoc wants to merge 1 commit into
cervengoc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the change
In WorkflowHost StartAsync if any exception occures, and there is no ActivityListener for WorkflowCore, then the catch block throws NullReferenceException due to accessing the null activity. This hides the original startup exception and makes impossible to see what had actually happen (eg. RabbitMQ queue provider connection issue, etc.)
Describe your implementation or design
Added a null-conditional operator to AddException
Tests
No
Breaking change
No