docs(humafiber): note streamed request bodies are not decoded - #1118
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
=======================================
Coverage 93.19% 93.19%
=======================================
Files 24 24
Lines 5008 5008
=======================================
Hits 4667 4667
Misses 273 273
Partials 68 68 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1111.
With
StreamRequestBodyenabled, humafiber passes the rawBodyStream()through, soContent-Encodingisn't decoded. Buffered bodies still go through Fiber'sBody()and arrive decoded (#928, #1058).This documents that behaviour rather than decoding in the adapter:
MaxBodyBytesalone doesn't cover it.Body()when streaming isn't safe: fasthttp reads the whole stream into memory without enforcing the body limit.Changes:
BodyReaderin both Fiber adapters explaining the passthrough.middleware.Decompress).