fix(work): Windows terminal Ctrl+C/Ctrl+V copy-paste (DAN-71) - #129
Merged
Merged
Conversation
Ctrl+C copies the xterm selection on Windows/Linux and still sends SIGINT when nothing is selected. Ctrl+V pastes through Terminal.paste. macOS ⌘C/⌘V and Ctrl+Shift+C/V stay on existing paths. Co-authored-by: Daniels <danielss-dev@users.noreply.github.com>
danielss-dev
marked this pull request as ready for review
September 16, 2026 11:05
danielss-dev
deleted the
developements/windows-terminal-clipboard-663b
branch
September 16, 2026 11:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows/Linux embedded Work terminals now follow VS Code / Windows Terminal clipboard behavior:
Terminal.paste.Implementation
Hook: xterm
Terminal.attachCustomKeyEventHandlerinTerminalPane(ui/src/views/Work.tsx), immediately afteronData.Decision helper:
terminalClipboardAction/consumeTerminalClipboardKeyinui/src/lib/terminalClipboard.ts. Copy uses existingcopyToClipboard; paste usesnavigator.clipboard.readTexttheninstance.paste.App.tsxstill does not reclaim Ctrl+C/Ctrl+V inside.work-terminal-hoston Windows/Linux (onlyMod+[1-8]). A comment now points at the TerminalPane handler so those keys stay terminal-owned.Linear: DAN-71
Proof
pnpm --filter ./ui exec tsc --noEmit— passpnpm --filter ./ui test— 97 files / 543 tests pass, including 11 new cases interminalClipboard.test.ts(selection copy, bare Ctrl+C forward, Ctrl+V paste, Shift variants, macOS no-claim, non-LatinKeyC/KeyV)Out of scope
Full keybinding redesign, external Open-in-terminal, WSL-only bugs.