Use executable icon for MSI Start Menu shortcut - #136
Draft
PatrickSys wants to merge 1 commit into
Draft
PatrickSys wants to merge 1 commit into
PatrickSys wants to merge 1 commit into
Conversation
PatrickSys
force-pushed
the
fix/windows-msi-shortcut-icon
branch
from
September 21, 2026 16:44
a46afb5 to
7d85df8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #135
After the update, the pin still opened Strand, but its saved icon path pointed to a missing Windows Installer file.
Tauri's MSI template sets
ProductIconon the Start Menu shortcut. This removes that setting so Windows can use the icon fromstrand.exe.Maintenance cost: Tauri has no per-shortcut icon setting, so this replaces its full WiX template with a Strand-owned copy. That copy will need to be synced when Tauri changes its template.
Still unverified: The exact update path and behavior during a Windows MSI upgrade with an existing pin. An old pin may need to be pinned again.