DAOS-18827 build: fix missing libisal2 dep in deb packages (#18057)#18493
Draft
daltonbohning wants to merge 1 commit into
Draft
DAOS-18827 build: fix missing libisal2 dep in deb packages (#18057)#18493daltonbohning wants to merge 1 commit into
daltonbohning wants to merge 1 commit into
Conversation
The --rpm-autoreq FPM option is RPM-only and silently no-ops when building Debian packages, causing the daos package to miss the libisal2 (libisal.so.2) dependency in .deb output. Remove the option and the associated noautoreq escape hatch in favour of uniform explicit dependency declarations across both packaging formats. Add the missing isal_lib dependency to the daos package. Skip-test: true Skip-unit-test: true Skip-unit-tests: true Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com> Signed-off-by: Dalton Bohning <dalton.bohning@hpe.com>
Contributor
Author
|
Just trying to see if this resolves another issue we are seeing |
|
Ticket title is 'DAOS Debian package missing libisal dependency and wrong executable permissions    ' |
github-actions
Bot
added
the
priority
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --rpm-autoreq FPM option is RPM-only and silently no-ops when building Debian packages, causing the daos package to miss the libisal2 (libisal.so.2) dependency in .deb output. Remove the option and the associated noautoreq escape hatch in favour of uniform explicit dependency declarations across both packaging formats.
Add the missing isal_lib dependency to the daos package.
Skip-test: true
Skip-unit-test: true
Skip-unit-tests: true
Steps for the author:
After all prior steps are complete: