MAINT: improve nanmax, nanmin and nansum - #939
Merged
Merged
Conversation
OmarManzoor
approved these changes
Aug 20, 2026
OmarManzoor
left a comment
OmarManzoor
left a comment
Contributor
There was a problem hiding this comment.
Looks nice! Thank you @qbarthelemy
Contributor
|
@lucascolley can we merge this? |
lucascolley
self-requested a review
August 20, 2026 09:47
lucascolley
changed the title
nanmax, nanmin and nansumnanmax, nanmin and nansum
lucascolley
approved these changes
Aug 21, 2026
lucascolley
left a comment
lucascolley
left a comment
Member
There was a problem hiding this comment.
great stuff, thanks both!
Member
|
@all-contributors please add @qbarthelemy for code |
Contributor
|
I've put up a pull request to add @qbarthelemy! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Related to #789
What does this implement/fix?
Simplify
nanmax,nanminandnansumfunctions, usinginstead of
Additional information
AI Generation Disclosure
No AI tools used, handmade