fix: unregister state change listeners on disconnect - #2
Open
BatLeDev wants to merge 1 commit into
Open
Conversation
onStateChange now returns an unregister function that DFrameElement stores on connect and calls on disconnect. Each mount/unmount cycle of a d-frame used to leak a vue watcher, a router afterEach hook or a popstate listener.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onStateChangenow returns a function to unregister the listener, whichDFrameElementstores inconnectedCallback()and calls indisconnectedCallback(). Applied to the three adapters:WindowStateChangeAdapterremoves itspopstatelistener,vue-reactivereturns theWatchStopHandle,vue-routerreturns the unregister functionafterEachalready provides.Why: every mount/unmount cycle of a
<d-frame>— editing a draft config, toggling dashboard columns — leaked a listener that kept firingupdateSrc()on a detached element. Not a correctness bug, but a cost that grows over a long session.Heads-up:
StateChangeAdapter.onStateChangenow returns() => voidinstead ofvoid— a breaking type change for any external adapter written in TypeScript. No such adapter exists in our own codebases, and the runtime stays tolerant (the handle is called with?.()).