acc: Shrink lifecycle-started warehouse tests to 2X-Small with 10min auto-stop#5583
Open
chrisst wants to merge 1 commit into
Open
acc: Shrink lifecycle-started warehouse tests to 2X-Small with 10min auto-stop#5583chrisst wants to merge 1 commit into
chrisst wants to merge 1 commit into
Conversation
…auto-stop The lifecycle-started SQL warehouse acceptance tests created Medium classic warehouses (n2-highmem-8 nodes with local SSD on GCP) with the default 120 minute auto-stop, and lifecycle.started: true actively started them on deploy. Leaked warehouses from these tests exhausted the LOCAL_SSD_TOTAL_GB_PER_VM_FAMILY quota (30TB) in the shared GCP test project, taking down all terraform provider CI. Shrink every cloud-running acceptance test that creates a classic warehouse to 2X-Small (roughly 8x smaller than Medium) and set auto_stop_mins: 10 (the classic-warehouse minimum) so any leaked warehouse stops itself quickly: - bundle/resources/sql_warehouses/lifecycle-started* - bundle/invariant/configs/sql_warehouse.yml.tmpl (was X-Small, no auto-stop) - bundle/resources/permissions/factcheck (was Small, no auto-stop) - bundle/config-remote-sync/multiple_resources (already 2X-Small, no auto-stop) Serverless warehouse configs (enable_serverless_compute: true) are left unchanged since they consume no GCE quota, as are testserver-only tests. Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: 1f5304b
32 interesting tests: 15 SKIP, 10 flaky, 7 KNOWN
Top 28 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Shrinks the SQL warehouses created by cloud acceptance tests to
2X-Smallwithauto_stop_mins: 10(wasMedium/X-Small/Smallwith the 120-minute default):bundle/resources/sql_warehouses/lifecycle-started+lifecycle-started-togglebundle/invariant/configs/sql_warehouse.yml.tmplbundle/resources/permissions/factcheckbundle/config-remote-sync/multiple_resources(already 2X-Small; adds auto-stop)Serverless configs are untouched (no GCE footprint), as is
lifecycle-started-terraform-error(covered by a separate PR).Why
These tests run against shared cloud test workspaces. On GCP, a
Mediumclassic warehouse runs n2-highmem-8 nodes with local SSD;lifecycle.started: truemeans deploy actively starts them, and leaks survive up to 2h on the default auto-stop. On 2026-06-11/12 leaked Medium warehouses exhaustedLOCAL_SSD_TOTAL_GB_PER_VM_FAMILY(30TB, us-central1) in the sharedgcp-dev-decoproject, blocking all terraform-provider integration tests for ~2 days (ref ES-1974228). 2X-Small + 10-minute auto-stop cuts the worst-case leak footprint ~8x in size and 12x in duration.Tests
Local testserver runs pass for all affected dirs (
bundle/resources/sql_warehouses,bundle/invariant,bundle/resources/permissions/factcheck,bundle/config-remote-sync/multiple_resources); recorded-request output files now assert the 2X-Small/10-min create bodies.This pull request and its description were written by Isaac.